2 Jan
2020
2 Jan
'20
10:39 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 34:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/cmos.layout:
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... PS31, Line 32: 456 1 e 1 ECC_memory
Hmmm, it seems a lot of other AMD boards have this "456 1 e 1 ECC_memory […]
I think you can comment it out (add a # at the beginning) so as to keep things aligned with other boards.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30987
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 34
Gerrit-Owner: Balázs Vinarz vinibali1@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz vinibali1@gmail.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jan 2020 21:39:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon mikebdp2@gmail.com
Gerrit-MessageType: comment