build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46584 )
Change subject: WIP: soc/mediatek/mt8192: add display debug log ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46584/1/src/soc/mediatek/mt8192/ddp... File src/soc/mediatek/mt8192/ddp.c:
https://review.coreboot.org/c/coreboot/+/46584/1/src/soc/mediatek/mt8192/ddp... PS1, Line 176: u32 lenght; 'lenght' may be misspelled - perhaps 'length'?
https://review.coreboot.org/c/coreboot/+/46584/1/src/soc/mediatek/mt8192/ddp... PS1, Line 211: for (i = 0; i < comp->lenght/4; i+=4, local_offset+=16) { 'lenght' may be misspelled - perhaps 'length'?
https://review.coreboot.org/c/coreboot/+/46584/1/src/soc/mediatek/mt8192/ddp... PS1, Line 211: for (i = 0; i < comp->lenght/4; i+=4, local_offset+=16) { spaces required around that '+=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46584/1/src/soc/mediatek/mt8192/ddp... PS1, Line 211: for (i = 0; i < comp->lenght/4; i+=4, local_offset+=16) { spaces required around that '+=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46584/1/src/soc/mediatek/mt8192/ddp... PS1, Line 228: for (i = 0; i < sizeof(dump_info)/ sizeof(struct module_info); i++) { need consistent spacing around '/' (ctx:VxW)