Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55856 )
Change subject: commonlib/region: Add support for asynchronous readat ......................................................................
Patch Set 5:
(6 comments)
File src/commonlib/include/commonlib/region.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123573): https://review.coreboot.org/c/coreboot/+/55856/comment/efe94026_70221cf5 PS5, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'const struct region_device *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123573): https://review.coreboot.org/c/coreboot/+/55856/comment/83861f5e_f7dbf1a8 PS5, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'struct rdev_readat_async_context *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123573): https://review.coreboot.org/c/coreboot/+/55856/comment/d6868a7e_ac82e75c PS5, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123573): https://review.coreboot.org/c/coreboot/+/55856/comment/143b715a_a2c8281e PS5, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123573): https://review.coreboot.org/c/coreboot/+/55856/comment/65844a66_00dd3347 PS5, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name
File src/commonlib/region.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123573): https://review.coreboot.org/c/coreboot/+/55856/comment/41803724_149f3000 PS5, Line 136: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters