Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38165/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38165/7//COMMIT_MSG@10 PS7, Line 10: acpi ACPI
https://review.coreboot.org/c/coreboot/+/38165/7//COMMIT_MSG@13 PS7, Line 13: TEST=Booted to kernel and verified the DMAR table contents. How did you verify it?
https://review.coreboot.org/c/coreboot/+/38165/7/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/38165/7/src/soc/intel/tigerlake/acp... PS7, Line 243: int unsigned
https://review.coreboot.org/c/coreboot/+/38165/7/src/soc/intel/tigerlake/acp... PS7, Line 244: i*8 Please add spaces around operators (also below).
https://review.coreboot.org/c/coreboot/+/38165/7/src/soc/intel/tigerlake/acp... PS7, Line 259: sa_get_gsm_base(), sa_get_tolud_base() - 1); Should fit in 96 characters?
https://review.coreboot.org/c/coreboot/+/38165/7/src/soc/intel/tigerlake/acp... PS7, Line 273: */ Please use allowed comment styles [1], and reflow for 96 characters.
[1]: https://doc.coreboot.org/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/38165/7/src/soc/intel/tigerlake/acp... PS7, Line 280: soc_fill_dmar); Fits in 96 characters?