Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35102/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35102/4//COMMIT_MSG@8
PS4, Line 8:
I can see what you are doing and have nothing against... but I believe you should explain why on the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d
Gerrit-Change-Number: 35102
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Comment-Date: Thu, 21 Nov 2019 15:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment