Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31063 )
Change subject: nb/intel/i945: Fix typo on DMIBAR32(0x334)
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31063/1/src/northbridge/intel/i945/early_ini...
File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/31063/1/src/northbridge/intel/i945/early_ini...
PS1, Line 512:
:
:
:
:
:
lol […]
Or maybe just bit 3 at 0x338 is RO. That's all we know.
Oh, wait did you remove all power in between? otherwise
the values of a previous boot might still stick... not
likely as 0x334 and 0x338 differ, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib894c24bc787c6c211da26dca78bcd330ded6681
Gerrit-Change-Number: 31063
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 16:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment
