Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37485 )
Change subject: arch|cpu/x86: Add Kconfig option for x86 reset vector ......................................................................
Patch Set 3:
(3 comments)
I am late for the review... -1 from me.
https://review.coreboot.org/c/coreboot/+/37485/3/src/arch/x86/failover.ld File src/arch/x86/failover.ld:
https://review.coreboot.org/c/coreboot/+/37485/3/src/arch/x86/failover.ld@17 PS3, Line 17: rom : ORIGIN = CONFIG_X86_RESET_VECTOR - 0xfff0, LENGTH = 64K This file is for romcc bootblocks only, I think you should have just leave this untouched.
The number 0xfffffff0 below is in some way tied to the default reset vector location so this script probably has some conflict now with a different X86_RESET_VECTOR value.
https://review.coreboot.org/c/coreboot/+/37485/3/src/arch/x86/id.ld File src/arch/x86/id.ld:
https://review.coreboot.org/c/coreboot/+/37485/3/src/arch/x86/id.ld@16 PS3, Line 16: .id (.): { I thought ID_SECTION_OFFSET is "defined" to be offset from the end of non-volatile memory and not really part of the bootblock stage.
https://review.coreboot.org/c/coreboot/+/37485/3/src/cpu/intel/fit/fit.ld File src/cpu/intel/fit/fit.ld:
https://review.coreboot.org/c/coreboot/+/37485/3/src/cpu/intel/fit/fit.ld@16 PS3, Line 16: .fit_pointer (.): { This should never move?