Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 154: PAD_CFG_GPI_SCI_LOW
After further investigation in hatch - eventhough the line is configured to be routed to APIC, there […]
I see it routed to I2C_IRQ on WLAN connector, since I2C SCL and SDA on connector is unstuffed, we are not using it, safe to configure as NC.
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 188: PAD_CFG_NF(GPP_D19, NONE, DEEP, NF2), : /* D20 : WWAN_WLAN_COEX2 */ : PAD_CFG_NF(GPP_D20, NONE, DEEP, NF2), : /* D21 : WWAN_WLAN_COEX3 */ : PAD_CFG_NF(GPP_D21, NONE, DEEP, NF1),
Looking at the previous platforms, I think it can be kept as NF1 for all the CoEX GPIOs. […]
Still I have the follow-up question regarding how the CoEX is managed for M.2 WLAN + WWAN.
for the discrete case? IIRC(checked with Anil too), these lines have to be routed between the Modules.