Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver
......................................................................
Patch Set 2:
Patch Set 2:
Matt, can you push the change you want? I am also wondering if IO address 0xc09 for EC was correct at all, and if LPC routing gets messed up if we remove the devicetree entry.
CB:41788
Almost positive the IO address was just a copy-pasta from a Google board and not actually correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156f38419bd3a3192c919045220062227eca5e7d
Gerrit-Change-Number: 41704
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 17:33:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment