Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59747 )
Change subject: soc/intel/common/pmc: Drop redundant pmc_ipc.c entry
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59747/comment/6c1e02f1_d4bfd2fd
PS1, Line 7: redundant
Strictly speaking, the removed entry is not redundant, as `pmc_ipc.c` is no longer compiled in when `PMC_IPC_ACPI_INTERFACE` is not enabled.
I'd simply use `unneeded` or `unnecessary` instead.
https://review.coreboot.org/c/coreboot/+/59747/comment/01d1b35b_f3724435
PS1, Line 9: redundant
Same as above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie66f0833daf033ec16210221610508f9fbb1e6c7
Gerrit-Change-Number: 59747
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subi.banik@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 30 Nov 2021 09:48:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment