Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )
Change subject: soc/amd/picasso: Use lookup table to convert MHz to MT/s
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45177/3/src/soc/amd/picasso/dmi.c
File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/3/src/soc/amd/picasso/dmi.c@7...
PS3, Line 72: return 0;
Could you return 2*speed_mhz so that it "maybe" works? In any case, keep the printk so that if someone's looking at the console, they can see that there was an issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45177
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc77c21932c68ee9f0ff0b8e35ae7b1a3732b322
Gerrit-Change-Number: 45177
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 00:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment