Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32705 )
Change subject: security/lockdown: Write-protect WP_RO
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32705/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32705/2//COMMIT_MSG@7
PS2, Line 7: security/lockdown: Write-protect WP_RO
Isnt it enough to explain in the details that we also added the ability to choose the *when*?
Done
https://review.coreboot.org/c/coreboot/+/32705/2/src/security/lockdown/bootm...
File src/security/lockdown/bootmedia.h:
https://review.coreboot.org/c/coreboot/+/32705/2/src/security/lockdown/bootm...
PS2, Line 16: void security_lockdown_bootmedia(void *unused);
Yes, but you created this header file. […]
I moved the declaration to boot_device.h and renamed the source file to lockdown.c. Also changed the function name to fit more to the convention. Hope this resolves this here :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72c3e1a0720514b9b85b0433944ab5fb7109b2a2
Gerrit-Change-Number: 32705
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Fri, 26 Jul 2019 08:46:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Gerrit-MessageType: comment