Attention is currently required from: Robert Zieba, Bao Zheng, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 )
Change subject: util: Add amdfwread utility
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
I took a deeper look into 54901 and it seems that amdfwtool is so focused on writing FW images that […]
ok, if it's easier and cleaner to have another tool for that, i'm ok with that. i'd strongly recommend to put the code for the new tool into the util/amdfwtool/ directory though, so that the code doesn't need to include things from a different directory which makes things more difficult to follow
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850
Gerrit-Change-Number: 62795
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 14:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment