[coreboot-gerrit] Change in coreboot[master]: arch/x86/acpigen: Add new helper routines for XOR and get_rx_gpio

[Rajat Jain (Code Review)]

Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39145 )

Change subject: arch/x86/acpigen: Add new helper routines for XOR and get_rx_gpio
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39145/1/Documentation/acpi/gpio.md 
File Documentation/acpi/gpio.md:

https://review.coreboot.org/c/coreboot/+/39145/1/Documentation/acpi/gpio.md@... 
PS1, Line 83: rx
> raw Rx

Done

https://review.coreboot.org/c/coreboot/+/39145/1/src/arch/x86/acpigen.c 
File src/arch/x86/acpigen.c:

https://review.coreboot.org/c/coreboot/+/39145/1/src/arch/x86/acpigen.c@1207 
PS1, Line 1207: uint9_t
> New data type ;).

Done

https://review.coreboot.org/c/coreboot/+/39145/2/src/arch/x86/acpigen.c 
File src/arch/x86/acpigen.c:

https://review.coreboot.org/c/coreboot/+/39145/2/src/arch/x86/acpigen.c@1776 
PS2, Line 1776: acpigen_write_xor
> Oops yeah, I believe our write_not() is bitwise Not, instead of LNot (logical not).

Done