Attention is currently required from: Paul Menzel, Weimin Wu, Karthik Ramasubramanian.
Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56804/comment/62e22de4_6dc5baf4
PS8, Line 2: field EXT_VR 17
: option EXT_VR_PRESENT 0
: option EXT_VR_ABSENT 1
: end
Please move this to baseboard devicetree, so that other projects dont overwrite this bit.
I have modified this place.
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56804/comment/e46482a9_10a6f5ba
PS8, Line 10: #ifdef USE_SKU_METHOD
Please use the FW_CONFIG approach.
I have modified this place.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 16 Aug 2021 12:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment