Name of user not set #1003143 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48557 )
Change subject: tests: Add lib/fmap-test test case
......................................................................
Patch Set 1:
Patch Set 1:
Strange that the tests with invalid parameters are causing a stack fault instead of returning an error; I wonder if the build is not pulling in the ancestor CL?
Build is correct. In ancestor commit I missed few functions that could crash the program.
Once again tests prove their usefulness. :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I885ea05d509d3b1330de7a18531f310d290c6965
Gerrit-Change-Number: 48557
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1003143
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 09:15:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment