Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44701 )
Change subject: soc/mediatek/mt8192: Do the dramc pinmux selection ......................................................................
Patch Set 28:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra... PS2, Line 9: const
const static
Ack
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra... PS2, Line 42: MRR
Lower case function name
Ack
https://review.coreboot.org/c/coreboot/+/44701/28/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44701/28/src/soc/mediatek/mt8192/dr... PS28, Line 14: { : },
Did you leave this blank on purpose?
Yes.