Attention is currently required from: Arthur Heymans, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80466?usp=email )
Change subject: device/pci_device.c: Avoid adding invalid resources
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80466/comment/7888103f_a69e3e92 :
PS1, Line 10:
Could you give an example?
a 32 bit only system can't have resources above 4gb. in this case the old code resulted in the second mmio region to have a base of 4GiB and a limit of 4 GiB - 1, so the limit is lower than the base. the code has a comment about this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80466?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60d1f34178a491e66e4e935fd1a3d02451d6ca23
Gerrit-Change-Number: 80466
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 20 Mar 2024 13:43:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment