[coreboot-gerrit] Change in coreboot[master]: soc/intel/apl: Add ACPI for SMBus control

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 )

Change subject: soc/intel/apl: Add ACPI for SMBus control
......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/44507/9/src/soc/intel/apollolake/ac... 
File src/soc/intel/apollolake/acpi/smbus.asl:

https://review.coreboot.org/c/coreboot/+/44507/9/src/soc/intel/apollolake/ac... 
PS9, Line 66: While ((Local1 == One))
maybe :
While (Local1 == One)

https://review.coreboot.org/c/coreboot/+/44507/9/src/soc/intel/apollolake/ac... 
PS9, Line 69: If ((Local3 != Zero))
maybe 
If (Local3 != Zero)

https://review.coreboot.org/c/coreboot/+/44507/9/src/soc/intel/apollolake/ac... 
PS9, Line 170: HSTS = (HSTS | 0xFF)
HSTS |= 0xFF