Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37458 )
Change subject: mb/google/kahlee/treeya: Tune VIH and meet spec ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37458/5/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37458/5/src/mainboard/google/kahlee... PS5, Line 28: uint32_t sku_id(void) : { : static int sku = -1; : : if (sku == -1) : sku = google_chromeec_get_sku_id(); : : return sku; : } : : uint8_t variant_board_sku(void) : { : return sku_id(); : } : : void variant_mainboard_suspend_resume(void) : { : /* Enable backlight - GPIO 133 active low */ : gpio_set(GPIO_133, 0); : }
Dear Raul, […]
Done
https://review.coreboot.org/c/coreboot/+/37458/5/src/mainboard/google/kahlee... PS5, Line 97: 0x304
Copy that, since this stage just do verification.
Done
https://review.coreboot.org/c/coreboot/+/37458/5/src/mainboard/google/kahlee... PS5, Line 100: 0x30
Copy that, since this stage just do verification.
Done