Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44102 )
Change subject: [WIP]mb/intel/minnowmax: Add mainboard ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 8: SPD_SOURCES = micron_2GiB_dimm_MT41K256M16HA-125 You could use `GENERIC_SPD` instead (see mb/hp/snb_ivb_laptops)
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 9: 0x1 0x3 for 2 ports?
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 33: device pci 00.0 on end # 8086 0F00 - SoC router - I'd clean up the comments around here
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 34: end align the `end` words?