Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28976 )
Change subject: mb/lenovo/*/romstage: Use macros instead of magic numbers ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c File src/mainboard/lenovo/l520/romstage.c:
https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c... PS3, Line 32: FDD_LPC_EN There's no floppy
https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c... PS3, Line 37: 0x000000) That's the power on default, no need to write it.
https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/l520/romstage.c... PS3, Line 42: RCBA32 Power on default ?
https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/s230u/romstage.... File src/mainboard/lenovo/s230u/romstage.c:
https://review.coreboot.org/#/c/28976/3/src/mainboard/lenovo/s230u/romstage.... PS3, Line 46: 0xd8 What's 0xd8 ? Can you add a MACRO for that ?