Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36445 )
Change subject: emulation/riscv: Don't probe for total DRAM ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36445/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/36445/1/src/mainboard/emulation/qem... PS1, Line 58: int "size of DRAM. Run qemu with the argument -m ***M" Isn't this the main problem? Ensuring the correct arguments are passed to qemu?
https://review.coreboot.org/c/coreboot/+/36445/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-riscv/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36445/1/src/mainboard/emulation/qem... PS1, Line 33: cbmem_recovery(0); This is not the right place for this.