build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40010 )
Change subject: sb/intel/bd82x6x/sata: Fix IDE legacy mode, plus more ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/sata.c:
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... PS1, Line 52: if ((res = find_resource(dev, PCI_BASE_ADDRESS_0))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... PS1, Line 59: if ((res = find_resource(dev, PCI_BASE_ADDRESS_1))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... PS1, Line 66: if ((res = find_resource(dev, PCI_BASE_ADDRESS_2))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... PS1, Line 73: if ((res = find_resource(dev, PCI_BASE_ADDRESS_3))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... PS1, Line 92: if ((res = find_resource(dev, i))) do not use assignment in if condition