Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr...
File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr...
PS6, Line 472: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(117) : VR_CFG_TDC_AMP(146);
how about if if (cfg->cpu_pl2_4_cfg == baseline) and tdc[VR_IA_CORE] = (tip >=65) ? :
i think the original one is more straightforward. keep untouched.
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr...
PS6, Line 502: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config and apply Auto/default settings\n", mch_id);
Should fix the indent
good finding.
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr...
PS6, Line 554: vr_params->TdcEnable[domain] = 0;
vr_params->TdcEnable[domain] = !cfg->tdc_disable
that's a good suggestion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4b17e5b4ce41c1adb436ae5646f0d8578a440e8
Gerrit-Change-Number: 38741
Gerrit-PatchSet: 6
Gerrit-Owner: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Feb 2020 02:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Marx Wang
marx.wang@intel.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment