Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 135: They offer similar functionality as Unity, while at the same time don’t seem If you decide to keep this section, indent this paragraph. Otherwise, it breaks up the bulleted list.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 140: Another one which is rather widely used, however it doesn't have good support Indent here if keeping this section
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 130: Three more frameworks should be mentioned here, however they weren't tried : within coreboot: : * [Check](https://libcheck.github.io/check/) : * [Criterion](https://github.com/Snaipe/Criterion/) : : They offer similar functionality as Unity, while at the same time don’t seem : to have similarly active communities. : : * [CUnit](http://cunit.sourceforge.net/) : : Another one which is rather widely used, however it doesn't have good support : for mocking. : : If anyone has good experience with some framework which is not listed above, it : will be highly appreciated to give a note about this to the author. In such : cases, it may be necessary to investigate such tools deeply and then reconsider : the decision. I'm not sure this section adds value any more. You could probably just reduce it to a sentence that says something like "We looked at several other test frameworks, but decided not to do a full evaluation for various reasons such as functionality, size of the developer community, or compatibility."
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 254: ├── build I know that 'build' will get listed first because of alphabetical order, but I suggest moving it to the end of the tree. 'src' comes first because the source code exits. Then we write the tests in the 'tests' tree. After we build the tests, we have the 'build' tree.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 285: one headers
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 285: replaces replace
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 298: test tests Use plural like the "Writing new tests" section below.