Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31416/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31416/1//COMMIT_MSG@9 PS1, Line 9: filed field
https://review.coreboot.org/#/c/31416/1//COMMIT_MSG@10 PS1, Line 10: Also fix some coding style Format that as a list/enumeration?
https://review.coreboot.org/#/c/31416/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/1/src/arch/x86/smbios.c@385 PS1, Line 385: /* As a work around to prevent a compiler error, temporarily specify : * 16 MiB flash sizes when ROM size >= 16 MiB. An update is necessary : * once the SMBIOS specification addresses ROM sizes > 16 MiB. : */ Why duplicate the comment?