[coreboot-gerrit] Change in coreboot[master]: security/intel/stm: Add STM support

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )

Change subject: security/intel/stm: Add STM support
......................................................................

Patch Set 46:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33234/46/src/include/cpu/x86/msr.h 
File src/include/cpu/x86/msr.h:

https://review.coreboot.org/c/coreboot/+/33234/46/src/include/cpu/x86/msr.h@... 
PS46, Line 60: #define IA32_VMX_MISC_MSR               0x485
(I don't know the answer to my question)
are the MCA_STATUS bit values below relates to the MC0_STATUS register at line 58? If so, lines 59 and 60 should move below them.

https://review.coreboot.org/c/coreboot/+/33234/46/src/security/intel/stm/Mak... 
File src/security/intel/stm/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33234/46/src/security/intel/stm/Mak... 
PS46, Line 12: #smm-$(CONFIG_STM) += StmPlatformResource.c
why is this commented out? I don't recall.