Attention is currently required from: Aseda Aboagye, Cliff Huang, Lance Zhao, Nick Vaccaro, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81895?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpigen_ps2_keybd: Add Fn key to linux,keymap
......................................................................
Patch Set 2:
(2 comments)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/81895/comment/3f13a6c3_5433b17c :
PS2, Line 19: default 0
Why this default?
https://review.coreboot.org/c/coreboot/+/81895/comment/e0be49da_3e82f0c6 :
PS2, Line 22: Fn key is pressed.
Mention that 0 is ignored?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81895?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c
Gerrit-Change-Number: 81895
Gerrit-PatchSet: 2
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment