Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )
Change subject: mb/google/asurada: Implement board-specific regulator controls. ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 8: MT6360_LDO3
Probably make it clear given you're starting with 3. e.g., […]
Ack
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17:
6359 implementation depends on CB:45399 which might take longer review process. […]
Ack
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 24: MTK_REGULATOR_VDD1: : break;
controlled by mt6359p
Ack
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 26: case MTK_REGULATOR_VDD2: : google_chromeec_regulator_set_voltage(MT6360_BUCK1, : voltage_mv, : voltage_mv); : break; : case MTK_REGULATOR_VDDQ: : google_chromeec_regulator_set_voltage(MT6360_LDO7, : voltage_mv, : voltage_mv); : break; : case MTK_REGULATOR_VMDDR: : google_chromeec_regulator_set_voltage(MT6360_LDO6, : voltage_mv, : voltage_mv); : break; : default: : printk(BIOS_WARNING, "Invalid regualtor ID: %d\n", regulator); : break; : }
int id = get_mt6360_regulator_id(regulator); […]
Ack