[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/speedstep: Add Netburst

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22604 )

Change subject: cpu/intel/speedstep: Add Netburst
......................................................................

Patch Set 66:

(2 comments)

https://review.coreboot.org/#/c/22604/66/src/cpu/intel/speedstep/acpi.c 
File src/cpu/intel/speedstep/acpi.c:

https://review.coreboot.org/#/c/22604/66/src/cpu/intel/speedstep/acpi.c@57 
PS66, Line 57: 	int fsb3 = get_ia32_fsb_x3();
This could be a separate change, with argument MSR_FSB_FREQ was not available with NetBurst?

https://review.coreboot.org/#/c/22604/66/src/cpu/intel/speedstep/speedstep.c 
File src/cpu/intel/speedstep/speedstep.c:

https://review.coreboot.org/#/c/22604/66/src/cpu/intel/speedstep/speedstep.c... 
PS66, Line 102: 			break;
Hmmm.. I don't like nested 'switch' statements that much. Doesn't this 'break' enter the default Merom values below?