Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47013 )
Change subject: mb/google/dedede/var/metaknight: Add device settings ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... PS1, Line 56: register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 90, 5000)" : register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 70, 6000)" : register "policies.passive[2]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 60, 5000)" Can you please update above passive policies in this below structured manner,
register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 90, 5000), [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 70, 6000), [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 60, 5000)}"
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... PS1, Line 60: register "policies.critical[0]" = "DPTF_CRITICAL(CPU, 105, SHUTDOWN)" : register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 80, SHUTDOWN)" : register "policies.critical[2]" = "DPTF_CRITICAL(TEMP_SENSOR_1, 80, SHUTDOWN)" Here also the same way as per above comment,
register "policies.critical" = "{ [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 80, SHUTDOWN), [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 80, SHUTDOWN)}"