build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32666 )
Change subject: coreboot: add md power off flow ......................................................................
Patch Set 1:
(63 comments)
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... File src/soc/mediatek/mt8183/include/soc/md_ctrl.h:
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 1: /* trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 2: * Copyright (C) 2019 MediaTek Inc. trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 3: * trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 4: * This program is free software: you can redistribute it and/or modify trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 5: * it under the terms of the GNU General Public License version 2 as trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 6: * published by the Free Software Foundation. trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 7: * trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 8: * This program is distributed in the hope that it will be useful, trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 9: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 10: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 11: * GNU General Public License for more details. trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 12: */ DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 13: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 14: #ifndef __SOC_MEDIATEK_MD_POWER_H__ DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 15: #define __SOC_MEDIATEK_MD_POWER_H__ DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 16: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 17: void mtk_md_early_init(void); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 18: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 19: #endif adding a line without newline at end of file
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c File src/soc/mediatek/mt8183/md_ctrl.c:
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@1 PS1, Line 1: /* trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@2 PS1, Line 2: * Copyright (C) 2019 MediaTek Inc. trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@3 PS1, Line 3: * trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@4 PS1, Line 4: * This program is free software: you can redistribute it and/or modify trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@5 PS1, Line 5: * it under the terms of the GNU General Public License version 2 as trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@6 PS1, Line 6: * published by the Free Software Foundation. trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@7 PS1, Line 7: * trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@8 PS1, Line 8: * This program is distributed in the hope that it will be useful, trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@9 PS1, Line 9: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@10 PS1, Line 10: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@11 PS1, Line 11: * GNU General Public License for more details. trailing whitespace
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@12 PS1, Line 12: */ DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@13 PS1, Line 13: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@13 PS1, Line 13: please, no spaces at the start of a line
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@14 PS1, Line 14: #include <device/mmio.h> DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@15 PS1, Line 15: #include <console/console.h> DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@16 PS1, Line 16: #include <soc/addressmap.h> DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@17 PS1, Line 17: #include <soc/infracfg.h> DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@18 PS1, Line 18: #include <soc/pll.h> DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@19 PS1, Line 19: #include <soc/md_ctrl.h> DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@20 PS1, Line 20: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@21 PS1, Line 21: static void internal_md1_power_down(void) DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@22 PS1, Line 22: { DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@23 PS1, Line 23: unsigned int reg_value; DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@24 PS1, Line 24: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@25 PS1, Line 25: /* 1. md clock setting: gating */ DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@26 PS1, Line 26: reg_value = read32(&mtk_topckgen->clk_mode); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@27 PS1, Line 27: reg_value |= ((1<<8)|(1<<9)); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@28 PS1, Line 28: write32(&mtk_topckgen->clk_mode, reg_value); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@29 PS1, Line 29: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@30 PS1, Line 30: /* 2. mixedsys topsm init, for release srcclkena in kernel */ DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@31 PS1, Line 31: reg_value = read32(&mt8183_infracfg->infra_misc2); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@32 PS1, Line 32: reg_value &= ~0xFF; DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@33 PS1, Line 33: write32(&mt8183_infracfg->infra_misc2, reg_value); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@34 PS1, Line 34: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@35 PS1, Line 35: printk(BIOS_INFO, "[ccci-off]src clk ena = 0x%X\n", DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@36 PS1, Line 36: read32(&mt8183_infracfg->infra_misc2)); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@37 PS1, Line 37: } DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@38 PS1, Line 38: DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@39 PS1, Line 39: void mtk_md_early_init(void) DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@40 PS1, Line 40: { DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@41 PS1, Line 41: internal_md1_power_down(); DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@42 PS1, Line 42: } DOS line endings
https://review.coreboot.org/#/c/32666/1/src/soc/mediatek/mt8183/md_ctrl.c@43 PS1, Line 43: DOS line endings