Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38267 )
Change subject: intel/e7505,i82801dx: Refactor raminit ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38267/1/src/northbridge/intel/e7505... File src/northbridge/intel/e7505/raminit.c:
https://review.coreboot.org/c/coreboot/+/38267/1/src/northbridge/intel/e7505... PS1, Line 1782: initialisation Minor: Though both forms are correct, now the spelling of this doesn't match the comment above.
https://review.coreboot.org/c/coreboot/+/38267/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801dx/i82801dx.h:
https://review.coreboot.org/c/coreboot/+/38267/1/src/southbridge/intel/i8280... PS1, Line 38: void i82801dx_early_init(void); : void enable_smbus(void); Now, these two do the same thing. I guess this change later?