Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32083 )
Change subject: payload/libpayload: This is a fix for potential NULL pointer dereferences ......................................................................
Patch Set 8: Code-Review-1
(4 comments)
https://review.coreboot.org/#/c/32083/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32083/8//COMMIT_MSG@7 PS8, Line 7: payload/libpayload: This is a fix for potential NULL pointer dereferences Please use:
libpayload: Fix potential NULL pointer dereference
https://review.coreboot.org/#/c/32083/8//COMMIT_MSG@10 PS8, Line 10: Just add a tag:
Found-by: Klockwork
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ehci... File payloads/libpayload/drivers/usb/ehci.c:
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ehci... PS8, Line 659: memory Also *DMA memory* here?
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ohci... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ohci... PS8, Line 703: memory DMA memory