Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46527 )
Change subject: mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46527/2/src/mainboard/asus/f2a85-m/...
File src/mainboard/asus/f2a85-m/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/46527/2/src/mainboard/asus/f2a85-m/...
PS2, Line 56: #endif /* CONFIG_BOARD_ASUS_F2A85_M_PRO */
I guess you could also skip the #if and use the CONFIG() as value:
#define BLDCFG_FCH_GPP_PORT2_PRESENT CONFIG(BOARD_ASUS_F2A85_PRO)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d60a212b0d249c7d8b3f8ec16baf5e93c985da
Gerrit-Change-Number: 46527
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Oct 2020 20:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment