Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39567 )
Change subject: ec/51nb: add support for NPCE985LA0DX EC
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39567/1/src/ec/51nb/npce985la0dx/np...
File src/ec/51nb/npce985la0dx/npce985la0dx.c:
https://review.coreboot.org/c/coreboot/+/39567/1/src/ec/51nb/npce985la0dx/np...
PS1, Line 14: */
Use SPDX header?
https://review.coreboot.org/c/coreboot/+/39567/1/src/ec/51nb/npce985la0dx/np...
PS1, Line 19: SuperIO
Super I/O
https://review.coreboot.org/c/coreboot/+/39567/1/src/ec/51nb/npce985la0dx/np...
PS1, Line 22: * functionality.
Fits on the line above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5798fad7fd18083cde1aa647fd91ca9c5ce963b7
Gerrit-Change-Number: 39567
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Mar 2020 22:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
