Attention is currently required from: Paul Menzel. Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57119 )
Change subject: driver/i2c/max98390: add dsm_param_name ......................................................................
Patch Set 16:
(5 comments)
File src/drivers/i2c/max98390/chip.h:
https://review.coreboot.org/c/coreboot/+/57119/comment/91861d4e_5f3563cd PS16, Line 16: dsm_param_name
`dsm_param_file_name` (then remove the comment)
Done
File src/drivers/i2c/max98390/max98390.c:
https://review.coreboot.org/c/coreboot/+/57119/comment/1e9dcc11_85a8ec20 PS16, Line 28: struct acpi_dp *dp = NULL;
Why?
Make sure the initialize to NULL, and we can judge whether DSD table is create or not.
https://review.coreboot.org/c/coreboot/+/57119/comment/79cb0b9d_0d2abbe4 PS16, Line 70: config->dsm_param_name);
Why also calling it in case `dp == NULL`?
When it's NULL, will create a table naming "_DSD" and add string "maxim,dsm_param_name" in _DSD table. if it's not NULL, _DST table is already created in CONFIG(CHROMEOS_DSM_CALIB) case and only add string "maxim,dsm_param_name" in _DSD table.
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/57119/comment/79cc044f_bdbba15e PS16, Line 73: config CHROMEOS_DSM_PARAM_NAME
CHROMEOS_DSM_PARAM_FILE_NAME
Done
https://review.coreboot.org/c/coreboot/+/57119/comment/5cc3dc1b_b70f0b32 PS16, Line 78: Management(DSM)
Please add a space before (.
Done