Attention is currently required from: Felix Singer, Himanshu Sahdev, Julius Werner, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75495?usp=email )
Change subject: Docs: Document coreboot's git commit message rules
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75495/comment/3875603f_5b96012d :
PS1, Line 6:
Subject line should not end with a period. […]
Done
https://review.coreboot.org/c/coreboot/+/75495/comment/1fac0f2a_97838c63 :
PS1, Line 7: commtit
:) Thanks, will fix.
Done
https://review.coreboot.org/c/coreboot/+/75495/comment/dbb0efde_dc4c8da3 :
PS1, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line) […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2ba681193e302318934cc2f7f30659eac73d099
Gerrit-Change-Number: 75495
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 03 Aug 2023 23:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-MessageType: comment