Max Blau has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32235 )
Change subject: mainboard: Add MSI MS-7707 ......................................................................
Patch Set 9: Code-Review-1
(3 comments)
This change is ready for review.
https://review.coreboot.org/#/c/32235/8/src/mainboard/msi/ms7707/romstage.c File src/mainboard/msi/ms7707/romstage.c:
https://review.coreboot.org/#/c/32235/8/src/mainboard/msi/ms7707/romstage.c@... PS8, Line 56: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x84, 0x000c0291);
only required if HWM is accessed in romstage
Ack
https://review.coreboot.org/#/c/32235/8/src/mainboard/msi/ms7707/romstage.c@... PS8, Line 88: pnp_write_config(dev, 0x27, 0x10); // PWOK follows Intel sequence
Should be part of devicetree
I've fought a lot with this. It did not work in devicetree at all in the beginning. Now it mysteriously does and i can just guess it was the initial 'LPC IF Enables Register' that had both CNF2_LPC_EN (4E/4F) and CNF1_LPC_EN (2E/2F) enabled at the same time and coreboot enabled the wrong confmode.
https://review.coreboot.org/#/c/32235/8/src/mainboard/msi/ms7707/romstage.c@... PS8, Line 99: pnp_write_config(dev, 0xd0, 0x20); // GPIO2 Output Enable
do you need superio GPIOs for raminit? […]
Ack