[coreboot-gerrit] [L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable

[Benjamin Doron (Code Review)]

Attention is currently required from: Sean Rhodes, Christian Walter, Angel Pons, Maximilian Brune, Lean Sheng Tan.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )

Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/prodrive/atlas/cfr.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/f2faf64e_f3f65c62 
PS2, Line 123: 			.ui_helptext	= "Specify what to do when power is re-applied "
             : 					  "after a power loss. This option has no effect "
             : 					  "on systems without a RTC battery.", /* TODO: check */
             : 
The help text is correct, to my knowledge. The RTC power well is the deepest (as in, lowest power), without a battery the PMC cannot preserve volatile registers.

Can we synchronise the default value with the Kconfig? Unfortunately, no actual Kconfig to use, so a ternary expression would do: `CONFIG(POWER_STATE_OFF_AFTER_FAILURE) ? MAINBOARD_POWER_STATE_OFF : MAINBOARD_POWER_STATE_ON`