Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35558 )
Change subject: src/device/dram/ddr4: Fix "Dead assignment" ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35558/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35558/2//COMMIT_MSG@7 PS2, Line 7: src/device/dram/ddr4: Fix "Dead assignment" No src/ prefix, please.
I know it's hard to find a good summary that covers independent changes... but please try to, or split the changes. "Fix Dead assignment" is clearly not the only thing this change does.
Now that the `return` was added, that is clearly the more important change here! For one thing, it fixes a really bad bug, and for another, it changes behaviour (what fixing a dead assignment doesn't).