build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28709 )
Change subject: sb/amd: Use 'unsigned int' to bare use of 'unsigned' ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... File src/southbridge/amd/amd8111/amd8111_smbus.h:
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 66: static int do_smbus_recv_byte(unsigned smbus_io_base, unsigned int device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 112: static int do_smbus_send_byte(unsigned smbus_io_base, unsigned int device, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 113: unsigned value) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 155: static int do_smbus_read_byte(unsigned smbus_io_base, unsigned int device, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 202: static int do_smbus_write_byte(unsigned smbus_io_base, unsigned int device, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 241: static int do_smbus_block_read(unsigned smbus_io_base, unsigned int device, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 242: unsigned cmd, u8 bytes, u8 *buf) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 298: static int do_smbus_block_write(unsigned smbus_io_base, unsigned int device, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_... PS1, Line 299: unsigned cmd, u8 bytes, const u8 *buf) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_sm... File src/southbridge/amd/amd8111/early_smbus.c:
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_sm... PS1, Line 63: static inline int smbus_block_read(unsigned int device, unsigned cmd, u8 bytes, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_sm... PS1, Line 69: static inline int smbus_block_write(unsigned int device, unsigned cmd, u8 bytes, Prefer 'unsigned int' to bare use of 'unsigned'