Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )
Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46624/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46624/2//COMMIT_MSG@9 PS2, Line 9: change elan touchscreen interrupt to LEVEL trigger to pass uniformity : test. Can you please add the following detail to the commit message:
ELAN and Goodix touchscreen devices used on voxel are I2C-HID devices and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4, the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.
References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...
https://review.coreboot.org/c/coreboot/+/46624/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46624/2/src/mainboard/google/voltee... PS2, Line 104: ACPI_IRQ_EDGE_LOW This is wrong too. Since this is an I2C-HID device the interrupt will have to be level triggered.