Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32363 )
Change subject: pcengines/apu2: implement POSTCAR_STAGE ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/postcar.c:
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... PS6, Line 21: /* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */ : outb(0xea, 0xcd6); : outb(0x1, 0xcd7); You want as little hardware init as possible in postcar stage. Do it in board_BeforeAgesa()?
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... PS6, Line 79: console_init(); Done in romstage_main in drivers/amd/agesa/romstage.c?
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... PS6, Line 80: : /* Load MPB */ : val = cpuid_eax(1); : printk(BIOS_DEBUG, "BSP Family_Model: %08x\n", val); Is this needed?