Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42737 )
Change subject: soc/intel/cannonlake: Add UWES ASL into xhci.asl ......................................................................
Patch Set 4:
(9 comments)
Patch Set 4:
(9 comments)
I think Patrick is right, we should switch to use new ASL syntax when possible
Thank you for showing me this! Done.
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 20: Add (Arg1, Multiply (Subtract (Arg0, 1), 0x10), Local0)
With new ASL syntax, I believe your comment can be the actual code now: […]
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 35: And (Local0, RO_BITS_OFF_MASK, Local0)
new syntax: […]
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 37: Or (Local0, WAKE_ON_CONNECT_DISCONNECT_ENABLE, Local0)
new syntax: […]
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 38: Store(Local0, PSCT)
PSCT = Local0
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 49: Store (Arg0, Local0)
Local0 = Arg0
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 53: If (LEqual (Local1, Zero))
If (Local1 == Zero)
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 62: And (Local0, Subtract (Local0, 1), Local0)
Local0 = Local0 & (Local0 - 1)
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 76: nd (\U2WE, 0xFFF)
\U2WE & 0xFFF
Done
https://review.coreboot.org/c/coreboot/+/42737/4/src/soc/intel/cannonlake/ac... PS4, Line 77: And (\U3WE, 0x3F )
\U3WE & 0x3F
Done