Attention is currently required from: Anil Kumar K, Pranava Y N, Varun Upadhyay.
Subrata Banik has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85074?usp=email )
Change subject: mb/google/fatcat: Add FW_CONFIG Support for ALC721 soundwire
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85074/comment/7af6c3d9_0e824dce?usp... :
PS2, Line 8: AUDIO_ALC721_SNDW
The external Audio Card (ALC721) goes to Link 3 (SND3) while the onboard ALC722 goes to link 1(SND1). That's the reason defined separate FW_CONFIG.
can you please check is this a static configuration that OS driver has relied on ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85074?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5ca1502942f0ca009db398589c4a243d9e2804c
Gerrit-Change-Number: 85074
Gerrit-PatchSet: 2
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Sun, 10 Nov 2024 15:48:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Varun Upadhyay
varun.upadhyay@intel.com