Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36836 )
Change subject: Make firmware update hardware version aware ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/em100/+/36836/1/firmware.c File firmware.c:
https://review.coreboot.org/c/em100/+/36836/1/firmware.c@203 PS1, Line 203: 4
HW_VERSION_4? I considered that, but I didn't feel that was going to be helpful. […]
How about: #define HWVER_GEN1 4 // or HWVER_ORIGINAL #define HWVER_GEN2 6
That way it's clearer that "4" is the old stuff, and that there's a 6, and that any other number is something we definitely don't support yet (suppose somebody skips Pro-G2 and sees versions 4 and 8, assuming that all non-4 code here is for "8")
https://review.coreboot.org/c/em100/+/36836/1/firmware.c@243 PS1, Line 243: em100->hwversion == 4
I have a followon patch in the queue. […]
Even then this is saying "this is an EM100Pro (non-G2) file if and only if there's also an EM100Pro (non-G2) attached)"