View Change
2 comments:
File firmware.c:
Patch Set #1, Line 203: 4
HW_VERSION_4? I considered that, but I didn't feel that was going to be helpful. […]
How about:
#define HWVER_GEN1 4 // or HWVER_ORIGINAL
#define HWVER_GEN2 6
That way it's clearer that "4" is the old stuff, and that there's a 6, and that any other number is something we definitely don't support yet (suppose somebody skips Pro-G2 and sees versions 4 and 8, assuming that all non-4 code here is for "8")
Patch Set #1, Line 243: em100->hwversion == 4
I have a followon patch in the queue. […]
Even then this is saying "this is an EM100Pro (non-G2) file if and only if there's also an EM100Pro (non-G2) attached)"
To view, visit change 36836. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ia284adca4cb4d341a8d229374b6ea0b5d2a5d5c0
Gerrit-Change-Number: 36836
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 14 Nov 2019 21:02:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer@coreboot.org>
Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: comment