Attention is currently required from: Jeremy Soller, Benjamin Doron, Angel Pons. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43615 )
Change subject: drivers/system76/dgpu: Add driver for System76 switchable graphics ......................................................................
Patch Set 7:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/43615/comment/9e0aba7f_1f4afcb3 PS6, Line 12: bootblock
Out of curiosity, why does this need to be done so early? I would guess it's needed for early PCIe i […]
I didn't notice any problem doing it in romstage (after cannonlake_memcfg_init).
File src/drivers/system76/dgpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/43615/comment/6d6b2cce_c5cc7fa1 PS6, Line 5:
Kconfig help text is indented with 2 extra spaces: […]
Done
File src/drivers/system76/dgpu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/43615/comment/b4e054e9_704b788e PS6, Line 3: //TODO: do not require this to be included in mainboard bootblock.c
I see why you need to do it this way: the `DGPU_RST_N` and `DGPU_PWR_EN` definitions are mainboard-s […]
I attempted to use a chip to set them in CB:57034, but can't get it to work.
https://review.coreboot.org/c/coreboot/+/43615/comment/c6c7c67a_0e5c0e50 PS6, Line 9: int
bool?
Done
https://review.coreboot.org/c/coreboot/+/43615/comment/a4d2b824_92292b45 PS6, Line 11: printk(BIOS_DEBUG, "system76: DGPU power %d\n", onoff);
nit: how about explicitly printing `on` and `off`? […]
Done
File src/drivers/system76/dgpu/ramstage.c:
https://review.coreboot.org/c/coreboot/+/43615/comment/6be6ac8a_5805f8bb PS6, Line 63: int
`unsigned int`?
Done
https://review.coreboot.org/c/coreboot/+/43615/comment/e9c54ac8_60bbceef PS6, Line 71: %p
Is there a need to print this pointer? This prints the address where the `struct device` resides, wh […]
Done
https://review.coreboot.org/c/coreboot/+/43615/comment/91f1ff6a_3fa5b592 PS6, Line 85: fn);
I haven't seen any dGPU with more than 2 functions (function 1 is usually audio), so I'd expect to a […]
NVIDIA GPUs have a max of 4 functions. fn 2 and 3 are for USB.
https://download.nvidia.com/XFree86/Linux-x86_64/470.63.01/README/dynamicpow...